Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Revert "Reduce the size of the HTTP connection pool for non-pushers" #15530

Merged
merged 2 commits into from
May 3, 2023

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented May 3, 2023

#15514 introduced a regression where Synapse would encounter
PartialDownloadErrors when fetching OpenID metadata for certain
providers on startup. Due to #8088, this prevents Synapse from starting
entirely.

Revert the change while we decide what to do about the regression.

@squahtx squahtx requested a review from a team as a code owner May 3, 2023 11:17
@squahtx squahtx added the X-Release-Blocker Must be resolved before making a release label May 3, 2023
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a description for why we're doing this. (And cross-link to the original PR.)

@squahtx
Copy link
Contributor Author

squahtx commented May 3, 2023

I've added a description. Does it look reasonable?

@clokep
Copy link
Member

clokep commented May 3, 2023

Yeah, looks good. 👍 Let's just merge without the newsfile.

@squahtx squahtx merged commit 3b837d8 into release-v1.83 May 3, 2023
@squahtx squahtx deleted the squah/revert_15514 branch May 3, 2023 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants