Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Switch InstanceLocationConfig to a pydantic BaseModel #15431

Merged
merged 12 commits into from
Apr 17, 2023
Merged

Switch InstanceLocationConfig to a pydantic BaseModel #15431

merged 12 commits into from
Apr 17, 2023

Commits on Apr 13, 2023

  1. Switch InstanceLocationConfig to a pydantic BaseModel, apply Strict* … 

    …types and add a few helper methods(that will make more sense in follow up work).
    @realtyem
    realtyem committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    adeb59c View commit details
    Browse the repository at this point in the history

  2. Changelog

    @realtyem
    realtyem committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6d05b7e View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Apply to fixes from review

    @realtyem
    realtyem committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    cae783f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Add docstring/comments to new ConfigModel.

    @realtyem
    realtyem committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    60d3cfd View commit details
    Browse the repository at this point in the history

  2. Try and abstract validation logic into wrapper function for better er… 

    …ror handling
    @realtyem
    realtyem committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    09657ff View commit details
    Browse the repository at this point in the history

  3. Change to feature.

    @realtyem
    realtyem committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    96f7154 View commit details
    Browse the repository at this point in the history

  4. Fix import to be compatible with older python versions(I hope)

    @realtyem
    realtyem committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    dd5a1a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Apply suggestions from code review 

    Co-authored-by: David Robertson <[email protected]>
    @realtyem @DMRobertson
    realtyem and DMRobertson authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6a7903c View commit details
    Browse the repository at this point in the history

  2. Change InstanceLocationConfigModel to just ConfigModel.

    @realtyem
    realtyem committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    28f03ce View commit details
    Browse the repository at this point in the history

  3. Rename parsing function to be clearer, and add type-ignore so mypy is… 

    … happier.
    @realtyem
    realtyem committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    cfe048e View commit details
    Browse the repository at this point in the history

  4. Update comment for ConfigModel.

    @realtyem
    realtyem committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ee620a0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into exp/unix-socket-repl-instance-map

    @realtyem
    realtyem authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fa35fc5 View commit details
    Browse the repository at this point in the history