This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Trust dtolnay/rust-toolchain #15406
Merged
Merged
Trust dtolnay/rust-toolchain #15406
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,12 +35,7 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| with: | ||
| toolchain: 1.58.1 | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - uses: matrix-org/setup-python-poetry@v1 | ||
| with: | ||
|
|
@@ -104,12 +99,7 @@ jobs: | |
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| with: | ||
| toolchain: 1.58.1 | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - uses: matrix-org/setup-python-poetry@v1 | ||
| with: | ||
|
|
@@ -126,12 +116,8 @@ jobs: | |
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| uses: dtolnay/[email protected] | ||
| with: | ||
| toolchain: 1.58.1 | ||
| components: clippy | ||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
|
|
@@ -148,10 +134,7 @@ jobs: | |
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| toolchain: nightly-2022-12-01 | ||
| components: clippy | ||
|
|
@@ -168,10 +151,7 @@ jobs: | |
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| # We use nightly so that it correctly groups together imports | ||
| toolchain: nightly-2022-12-01 | ||
|
|
@@ -236,12 +216,7 @@ jobs: | |
| postgres:${{ matrix.job.postgres-version }} | ||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| with: | ||
| toolchain: 1.58.1 | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - uses: matrix-org/setup-python-poetry@v1 | ||
|
|
@@ -281,12 +256,7 @@ jobs: | |
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| with: | ||
| toolchain: 1.58.1 | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
| # There aren't wheels for some of the older deps, so we need to install | ||
|
|
@@ -402,12 +372,7 @@ jobs: | |
| run: cat sytest-blacklist .ci/worker-blacklist > synapse-blacklist-with-workers | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| with: | ||
| toolchain: 1.58.1 | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - name: Run SyTest | ||
|
|
@@ -547,12 +512,7 @@ jobs: | |
| path: synapse | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| with: | ||
| toolchain: 1.58.1 | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - uses: actions/setup-go@v4 | ||
|
|
@@ -580,12 +540,7 @@ jobs: | |
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| with: | ||
| toolchain: 1.58.1 | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - run: cargo test | ||
|
|
@@ -603,10 +558,7 @@ jobs: | |
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Rust | ||
| # There don't seem to be versioned releases of this action per se: for each rust | ||
| # version there is a branch which gets constantly rebased on top of master. | ||
| # We pin to a specific commit for paranoia's sake. | ||
| uses: dtolnay/rust-toolchain@fc3253060d0c959bea12a59f10f8391454a0b02d | ||
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| toolchain: nightly-2022-12-01 | ||
| - uses: Swatinem/rust-cache@v2 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Trust dtonlay/rust-toolchain in CI. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean this is now versioned and the comment is obsolete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is still accurate: the underlying logic/mechanism of the action isn't associated to a release of the action.
However this bit of the comment
is what I'm disputing. I don't think the paranoia is justified.
(We [Synapse] talked about this during our Monday meeting, but I think you were out that day---see the notes at the bottom of the minutes.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've amended the description with words along these lines.