Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Revert "Reintroduce membership tables event stream ordering" #15347

Conversation

erikjohnston
Copy link
Member

Reverts #15128

cc. @Fizzadar

The ALTER TABLE took a long time on matrix.org (multiple minutes before being cancelled), while holding a lock that blocked all message sending

@erikjohnston erikjohnston marked this pull request as ready for review March 29, 2023 12:23
@erikjohnston erikjohnston requested a review from a team as a code owner March 29, 2023 12:23
@erikjohnston
Copy link
Member Author

I'm going to merge this to allow us to deploy develop on matrix.org

@erikjohnston erikjohnston merged commit 5350b5d into develop Mar 29, 2023
@erikjohnston erikjohnston deleted the revert-15128-membership-tables-event-stream-ordering-redux branch March 29, 2023 12:24
@Fizzadar
Copy link
Contributor

Ouch. I didn’t think adding columns required locks in postgres? Not sure how best to proceed for this

Fizzadar added a commit to beeper/synapse-legacy-fork that referenced this pull request Mar 30, 2023
Fizzadar added a commit to Fizzadar/synapse that referenced this pull request Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants