Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Have replication clients remove _INT_STREAM_POS #15309

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Have replication clients remove _INT_STREAM_POS #15309

merged 2 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. Have replication clients remove _INT_STREAM_POS 

    Suppose worker A makes an internal http request from worker B. B may
make changes that A later learns about over replication. We want A's
request to block until it has seen those changes—mainly to ensure A's
caches are invalidated promptly. This helps provide read-after-write
consistency, eliminating entire categories of races and test flakes.

To implement this, B includes a top-level field `_INT_STREAM_POS` in its
response JSON. Roughly speaking, the field's value tells A what to wait
for. But we weren't removing that internal field before A's request
completed!

Introduced in #14820.
Fixes #15308.
    David Robertson committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    202b363 View commit details
    Browse the repository at this point in the history

  2. Changelog

    David Robertson committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d098538 View commit details
    Browse the repository at this point in the history