Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix "Re-starting finished log context" spam when creating events #14947

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix "Re-starting finished log context" spam when creating events #14947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e575a34
Fix "Re-starting finished log context" spam when creating events
Jan 30, 2023
b2bfe13
fixup newsfile
Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/14947.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a long-standing bug where sending messages on servers with presence enabled would spam "Re-starting finished log context" log lines.
4 changes: 3 additions & 1 deletion synapse/handlers/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,7 +1939,9 @@ async def persist_and_notify_client_events(
if event.type == EventTypes.Message:
# We don't want to block sending messages on any presence code. This
# matters as sometimes presence code can take a while.
run_in_background(self._bump_active_time, requester.user)
run_as_background_process(
"bump_presence_active_time", self._bump_active_time, requester.user
)

async def _notify() -> None:
try:
Expand Down