Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix type hints in knocking tests #14887

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Fix type hints in knocking tests #14887

merged 6 commits into from
Jan 25, 2023

Commits on Jan 21, 2023

  1. Add a TestCaseProtocol class to help type unit test mixins 

    mypy recommends this in order to properly type mixins. The mixin class
should inherit from the protocol, and any class using the mixin must
provide the properties that the protocol defines.
    @anoadragon453
    anoadragon453 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    96465b8 View commit details
    Browse the repository at this point in the history

  2. Have mixin inherit from HomeserverTestCaseProtocol 

    This stops mypy complaining that KnockingStrippedStateEventHelperMixin
doesn't have 'hs' or 'get_success' attributes
    @anoadragon453
    anoadragon453 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    065e9f4 View commit details
    Browse the repository at this point in the history

  3. Remove tests/federation/transport/test_knocking.py from the mypy excl… 

    …ude list
    @anoadragon453
    anoadragon453 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    3bec531 View commit details
    Browse the repository at this point in the history

  4. changelog

    @anoadragon453
    anoadragon453 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    c132222 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. Remove HomeserverTestCaseProtocol and just inherit from HomeserverTes… 

    …tCase
    @anoadragon453
    anoadragon453 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    55428c4 View commit details
    Browse the repository at this point in the history

  2. Mess around until mypy doesn't emit errors

    @anoadragon453
    anoadragon453 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    082b3b4 View commit details
    Browse the repository at this point in the history