Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Delete event_push_summary_unique_index again. #14669

Merged
merged 5 commits into from
Dec 14, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/14669.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.70.0 which could cause spurious `UNIQUE constraint failed` errors in the `rotate_notifs` background job.
27 changes: 27 additions & 0 deletions synapse/storage/schema/main/delta/73/23_fix_thread_index.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/* Copyright 2022 The Matrix.org Foundation C.I.C
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

-- If a Synapse install made a large jump in versions (from < 1.62.0 to >= 1.70.0)
-- in a single upgrade then it might be possible for the event_push_summary_unique_index
-- to be added from delta 71/02event_push_summary_unique.sql and not deleted in
-- 73/06thread_notifications_thread_id_idx.sql.
--
-- See https://github.com/matrix-org/synapse/issues/14641

-- Stop this from happening on newly updated Synapses.
DELETE FROM background_updates WHERE update_name = 'event_push_summary_unique_index';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sanity checked to see if we need to update UNIQUE_INDEX_BACKGROUND_UPDATES. It doesn't look like it: that only mentions the newest index, event_push_summary_unique_index2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Thanks for checking!


-- Fix broken Synapses.
DROP INDEX IF EXISTS event_push_summary_unique_index;