This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Refactor MSC3030 /timestamp_to_event
to move away from our snowflake pull from destination
pattern
#14096
Merged
MadLittleMods
merged 13 commits into
develop
from
madlittlemods/13944-fix-msc3030-jump-to-date-complement-backfill-test-flake
Oct 26, 2022
Merged
Refactor MSC3030 /timestamp_to_event
to move away from our snowflake pull from destination
pattern
#14096
MadLittleMods
merged 13 commits into
develop
from
madlittlemods/13944-fix-msc3030-jump-to-date-complement-backfill-test-flake
Oct 26, 2022
Commits on Oct 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8867831 - Browse repository at this point
Copy the full SHA 8867831View commit details -
Configuration menu - View commit details
-
Copy full SHA for f03a2b6 - Browse repository at this point
Copy the full SHA f03a2b6View commit details -
Fix Complement MSC3030 `can_paginate_after_getting_remote_event_from_…
…timestamp_to_event_endpoint` test flake. Make sure we backfill the closest local event if it's an `outlier` so we can use it with `/context` and paginate `/messages` from this point. Previously we only did this for a remote event. Fix #13944 Why did this fail before? Why was it flakey? ==================================================== Sleuthing the server logs on the CI failure, it looks like `hs2:/timestamp_to_event` found `$NP6-oU7mIFVyhtKfGvfrEQX949hQX-T-gvuauG6eurU` as an `outlier` event locally. Then when we went and asked for it via `/context`, since it's an `outlier`, it was filtered out of the results -> `You don't have permission to access that event.` This is reproducible when `sync_partial_state` races and persists `$NP6-oU7mIFVyhtKfGvfrEQX949hQX-T-gvuauG6eurU` as an `outlier` before we evaluate `get_event_for_timestamp(...)`. To consistently reproduce locally, just add a delay at the [start of `get_event_for_timestamp(...)`](https://github.com/matrix-org/synapse/blob/cb20b885cb4bd1648581dd043a184d86fc8c7a00/synapse/handlers/room.py#L1470-L1496) so it always runs after `sync_partial_state` completes. ```py from twisted.internet import task as twisted_task d = twisted_task.deferLater(self.hs.get_reactor(), 3.5) await d ``` In a run where it passes, on `hs2`, `get_event_for_timestamp(...)` finds a different event locally which is next to a gap and we request from a closer one from `hs1` which gets backfilled. And since the backfilled event is not an `outlier`, it's returned as expected during `/context`. Future changes ========================== In a future PR, it would be nice if `/context` would just backfill the event for us. This would also help with #3848
Configuration menu - View commit details
-
Copy full SHA for 7c82755 - Browse repository at this point
Copy the full SHA 7c82755View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce3984 - Browse repository at this point
Copy the full SHA 3ce3984View commit details -
Configuration menu - View commit details
-
Copy full SHA for 720788d - Browse repository at this point
Copy the full SHA 720788dView commit details -
Configuration menu - View commit details
-
Copy full SHA for da87def - Browse repository at this point
Copy the full SHA da87defView commit details
Commits on Oct 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7332df1 - Browse repository at this point
Copy the full SHA 7332df1View commit details
Commits on Oct 19, 2022
-
Merge branch 'develop' into madlittlemods/13944-fix-msc3030-jump-to-d…
…ate-complement-backfill-test-flake
Configuration menu - View commit details
-
Copy full SHA for 482629b - Browse repository at this point
Copy the full SHA 482629bView commit details -
Remove trying to backfill local event since we no longer deal with ou…
…tliers See: - #14096 (comment) - #14096 (comment)
Configuration menu - View commit details
-
Copy full SHA for a57fceb - Browse repository at this point
Copy the full SHA a57fcebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f86fef - Browse repository at this point
Copy the full SHA 7f86fefView commit details
Commits on Oct 25, 2022
-
Merge branch 'develop' into madlittlemods/13944-fix-msc3030-jump-to-d…
…ate-complement-backfill-test-flake
Configuration menu - View commit details
-
Copy full SHA for 79f2fea - Browse repository at this point
Copy the full SHA 79f2feaView commit details -
Avoid f-string with logger to prevent unnecessary string interpolatio…
…n when not logging at that severity See #14096 (comment)
Configuration menu - View commit details
-
Copy full SHA for 25ce11c - Browse repository at this point
Copy the full SHA 25ce11cView commit details -
Co-authored-by: Erik Johnston <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 64a907a - Browse repository at this point
Copy the full SHA 64a907aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.