This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Apply & bundle edits for non-message events. #14034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squahtx
approved these changes
Oct 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Synapse only fetches edits for
m.room.messageevents, this is not correct according to the specification. It should apply for all types of events.This manifest in two related bugs (see below):
m.room.message.m.new_contentis not applied where available.Due to the structure of our code both of these have the same room cause, which is simply that we enforce that the event type must be
m.room.messagewhen fetching edits from the database. We relax that in this PR.Note that I didn't modify any tests since the current tests send
m.room.messageevents, which is still valid.Fixes #12793, fixes #12503