This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This claims to fix more memory leaks. Could have automated this upgrade with #11828 if we wanted.
I asked @tomsisk if he'd be willing to try a build with this frozendict bump. If you get a chance to do so, could you let me know what you find as a comment on this PR? (Even if there is no difference, it'd still be good to know.) Let me know if you need a hand building the docker container. I think you want:
|
DMRobertson
added
the
X-Needs-Info
This issue is blocked awaiting information from the reporter
label
Sep 30, 2022
@tomsisk Argh, sorry to hear this didn't help. I'll open a new issue based on your comment---it contains useful diagnostics, though it does seem like this is going to be very tricky to pin down. (I probably shouldn't have started a discussion on a PR anyway, sorry.) |
DMRobertson
removed
the
X-Needs-Info
This issue is blocked awaiting information from the reporter
label
Oct 6, 2022
clokep
approved these changes
Oct 7, 2022
Going to assume the complement failure is a flake (partial joins, device lists...) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This claims to fix more memory leaks, though from testing (see below) it apparently doesn't help people who are suffering pain when using presence.
Could have automated this upgrade with #11828 if we wanted.