Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Disable autocorrect and autocaptialisation when entering username for SSO registration. #13350

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Disable autocorrect and autocaptialisation when entering username for SSO registration. #13350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bd2b29
Disable autocorrect and autocaptialisation on SSO.
pixlwave Jul 21, 2022
7e57c18
Update changelog.d/13350.bugfix
erikjohnston Jul 26, 2022
8611f09
Merge branch 'develop' into doug/disable-auto-correct
erikjohnston Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13350.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Disabled autocorrection and autocapitalisation on the username text field shown during registration when using SSO.
erikjohnston marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion synapse/res/templates/sso_auth_account_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ <h1>Create your account</h1>
<div class="username_input" id="username_input">
<label for="field-username">Username (required)</label>
<div class="prefix">@</div>
<input type="text" name="username" id="field-username" value="{{ user_attributes.localpart }}" autofocus>
<input type="text" name="username" id="field-username" value="{{ user_attributes.localpart }}" autofocus autocorrect="off" autocapitalize="none">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see autocorrect at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#non-standard_attributes, but not autocapitalize. Do you have a reference for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, theres one over at Apple here: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#//apple_ref/doc/uid/TP40008058-autocapitalize

<div class="postfix">:{{ server_name }}</div>
</div>
<output for="username_input" id="field-username-output"></output>
Expand Down