This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide more info why we don't have any thumbnails to serve #13038
Provide more info why we don't have any thumbnails to serve #13038
Changes from 2 commits
4dc6e1a
4bf53bc
9348242
a3362a5
9381001
74aaf9c
9a6b85b
f881c39
ad5aa80
ac9285f
67c13ab
ff73222
d3308f8
990450f
6a42925
52ee48f
06405db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still think this should be a 404 and M_NOT_FOUND.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec says no right now, matrix-org/matrix-spec#1122
It does make sense to me in some cases:
In the cases I ran into,
400
makes more sense since the media did exist, Synapse just didn't thumbnail it.