This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Client / Server Auth Refactor #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient/server auth more general.
2) Change places where we mean unauthenticated to 401, not 403, in C/S v2: hack so it stays as 403 in v1 because web client relies on it.
…e expect, that's just fine. I added the user_id (as in database pkey) and it broke: no point testing what that comes out as: it's determined by the db.
…append' flag in the API.
… modifying (captcha setup is now purely on the HS).
…should fix it so that doesn't need the key in two different places)
* Now only the auth part goes to fallback, not the whole operation * Auth fallback is a normal API endpoint, not a static page * Params like the recaptcha pubkey can just live in the config Involves a little engineering on JsonResource so its servlets aren't always forced to return JSON. I should document this more, in fact I'll do that now.
…thout it just succeeding
… in the session: it's probably too open to abuse.
Conflicts: synapse/http/server.py
| if 'bind' in body and body['bind']: | ||
| logger.debug("Binding emails %s to %s" % ( | ||
| threepid, auth_user.to_string() | ||
| )) |
There was a problem hiding this comment.
You don't need to call "% ()" explicitly when logging:
logging.debug("Binding emails %s to %s", threepid, auth_user.to_string())
| defer.returnValue((False, ret, clientdict)) | ||
|
|
||
| @defer.inlineCallbacks | ||
| def add_oob_auth(self, stagetype, authdict, clientip): |
There was a problem hiding this comment.
I think this could do with some doc string to explain what "add_oob_auth" does and what the return value means.
|
LGTM |
NegativeMjark
added a commit
that referenced
this pull request
Apr 28, 2015
Client / Server Auth Refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...including password reset.