Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Prefer make_awaitable over defer.succeed in tests #12505

Merged
merged 9 commits into from
Apr 27, 2022
Merged

Prefer make_awaitable over defer.succeed in tests #12505

merged 9 commits into from
Apr 27, 2022

Commits on Apr 19, 2022

  1. Support DoneAwaitable and make_awaitable in run_in_background 

    Signed-off-by: Sean Quah <[email protected]>
    Sean Quah committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    2ff6425 View commit details
    Browse the repository at this point in the history

  2. Prefer make_awaitable over defer.succeed in tests 

    When configuring the return values of mocks, prefer awaitables from
`make_awaitable` over `defer.succeed`. `Deferred`s are only awaitable
once, so it is inappropriate for a mock to return the same `Deferred`
multiple times.

Signed-off-by: Sean Quah <[email protected]>
    Sean Quah committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    d56d118 View commit details
    Browse the repository at this point in the history

  3. Prefer make_awaitable over defer.succeed in `tests/rest/client/te… 

    …st_transactions.py`

Signed-off-by: Sean Quah <[email protected]>
    Sean Quah committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    301bfe3 View commit details
    Browse the repository at this point in the history

  4. Add newsfile 

    Signed-off-by: Sean Quah <[email protected]>
    Sean Quah committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    9718ba7 View commit details
    Browse the repository at this point in the history

  5. Appease mypy

    Sean Quah committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    180ab40 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Reword comments and reduce indent

    Sean Quah committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    629ce1b View commit details
    Browse the repository at this point in the history

  2. run linter

    Sean Quah committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    ba28da5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. refactor run_in_background

    Sean Quah committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    daa0e9a View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Move awaiter function to top-level

    Sean Quah committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    8ffb491 View commit details
    Browse the repository at this point in the history