Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow for the configuration of max request retries and min/max retry delays in the matrix federation client #12504

Merged
merged 10 commits into from
Jun 9, 2023

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Apr 19, 2022

Add some experiment config options that allow for the configuration of max request retries and min/max retry delays in the matrix federation client.

@H-Shay H-Shay requested a review from a team as a code owner April 19, 2022 18:15
@H-Shay H-Shay marked this pull request as draft April 19, 2022 18:15
@H-Shay H-Shay requested review from erikjohnston and removed request for a team April 19, 2022 18:15
synapse/http/matrixfederationclient.py Outdated Show resolved Hide resolved
synapse/http/matrixfederationclient.py Outdated Show resolved Hide resolved
@MatMaul MatMaul reopened this Jun 2, 2023
@MatMaul
Copy link
Contributor

MatMaul commented Jun 2, 2023

Config options has been moved to federation section instead of experimental along the merge.

@MatMaul
Copy link
Contributor

MatMaul commented Jun 7, 2023

A parameter to specify the timeout has also been added.

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a bit more formal language for the user facing docs. Otherwise LGTM

docs/usage/configuration/config_documentation.md Outdated Show resolved Hide resolved
docs/usage/configuration/config_documentation.md Outdated Show resolved Hide resolved
docs/usage/configuration/config_documentation.md Outdated Show resolved Hide resolved
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a bit more formal language for the user facing docs. Otherwise LGTM

@MatMaul MatMaul self-assigned this Jun 8, 2023
@MatMaul MatMaul merged commit d84e661 into develop Jun 9, 2023
@MatMaul MatMaul deleted the shay/configure_fed_client branch June 9, 2023 07:00
@MatMaul MatMaul added the Z-Time-Tracked Element employees should track their time spent on this issue/PR. label Jun 9, 2023
MatMaul pushed a commit that referenced this pull request Jun 14, 2023
…x retry delays in the matrix federation client (#12504)"

This reverts commit d84e661.
MatMaul pushed a commit that referenced this pull request Jun 15, 2023
…delays in the matrix federation client (#12504)


Co-authored-by: Mathieu Velten <[email protected]>
Co-authored-by: Erik Johnston <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Time-Tracked Element employees should track their time spent on this issue/PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants