Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Better error message when failing to request from another process #12060

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Better error message when failing to request from another process #12060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d48c695
Better error message when failing to request from another process
erikjohnston Feb 22, 2022
a07b2e4
Newsfile
erikjohnston Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12060.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix error message when a worker process fails to talk to another worker process.
4 changes: 3 additions & 1 deletion synapse/replication/http/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,9 @@ async def send_request(*, instance_name: str = "master", **kwargs: Any) -> Any:
raise e.to_synapse_error()
except Exception as e:
_outgoing_request_counter.labels(cls.NAME, "ERR").inc()
raise SynapseError(502, "Failed to talk to main process") from e
raise SynapseError(
502, f"Failed to talk to {instance_name} process"
) from e

_outgoing_request_counter.labels(cls.NAME, 200).inc()
return result
Expand Down