Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Hotfixes: Revert commit() OpenTracing hackery #11906

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Hotfixes: Revert commit() OpenTracing hackery #11906

merged 2 commits into from
Feb 4, 2022

Conversation

reivilibre
Copy link
Contributor

No description provided.

@babolivier babolivier mentioned this pull request Feb 4, 2022
Merged
@reivilibre reivilibre marked this pull request as ready for review February 4, 2022 10:13
@reivilibre reivilibre requested a review from a team as a code owner February 4, 2022 10:13
@babolivier
Copy link
Contributor

For the paper trail: This reverts 5cc41f1 (first commit) and 99e7fb1 (second commit)

@babolivier babolivier self-assigned this Feb 4, 2022
babolivier
babolivier approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though not sure what to do with the CI

@richvdh
Copy link
Member

richvdh commented Feb 4, 2022

not sure what to do with the CI

we should just sort out #4826 and be done

@richvdh richvdh mentioned this pull request Feb 4, 2022
Open
@reivilibre reivilibre merged commit 3bf4666 into matrix-org-hotfixes Feb 4, 2022
@reivilibre reivilibre deleted the rei/moh_revert_commit_tracing_hacks branch February 4, 2022 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@babolivier babolivier babolivier approved these changes

Assignees

@babolivier babolivier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reivilibre @babolivier @richvdh