Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix comments in PR #10969 #11212

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Fix comments in PR #10969 #11212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a8bd8a
Fix comments in PR #10969
dklimpel Oct 29, 2021
c9d9e9a
newsfile
dklimpel Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11212.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a long-standing bug where messages in the `device_inbox` table for deleted devices would persist indefinitely. Contributed by @dklimpel and @JohannesKleine.
2 changes: 1 addition & 1 deletion synapse/storage/databases/main/deviceinbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ async def _remove_deleted_devices_from_device_inbox(
) -> int:
"""A background update that deletes all device_inboxes for deleted devices.

This should only need to be run once (when users upgrade to v1.46.0)
This should only need to be run once (when users upgrade to v1.47.0)

Args:
progress: JsonDict used to store progress of this background update
Expand Down
2 changes: 1 addition & 1 deletion synapse/storage/schema/main/delta/64/02remove_deleted_devices_from_device_inbox.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@


-- Remove messages from the device_inbox table which were orphaned
-- when a device was deleted using Synapse earlier than 1.46.0.
-- when a device was deleted using Synapse earlier than 1.47.0.
-- This runs as background task, but may take a bit to finish.

INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
Expand Down