Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commits on Oct 7, 2021

  1. Fix exception thrown when attempting to notify appservice sender

    Fix #11025
    
    Before in [`user_directory_handler._handle_deltas`, we just checked for `is_support_user(user_id)`](https://github.com/matrix-org/synapse/pull/10960/files#diff-e02a9a371e03b8615b53c6b6552f76fc7d3ef58931ca64d28b3512caf305449fL232) which works just fine.
    Now with #10960, we [call `should_include_local_user_in_dir`](https://github.com/matrix-org/synapse/pull/10960/files#diff-e02a9a371e03b8615b53c6b6552f76fc7d3ef58931ca64d28b3512caf305449fR229) which does a [bunch of additional checks](https://github.com/matrix-org/synapse/blob/e79ee48313404abf8fbb7c88361e4ab1efa29a81/synapse/storage/databases/main/user_directory.py#L382-L398) which aren't all compatible with the main appservice sender (main bridge user/sender). More specifically, we can't check the `users` database table for whether the user is deactivated.
    
    In the `should_include_local_user_in_dir` checks, we should return early if we encounter a main appservice sender before the incompatible checks.
    MadLittleMods committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    2c7c5c2 View commit details
    Browse the repository at this point in the history
  2. Add changelog

    MadLittleMods committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    ede2a70 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Merge branch 'develop' into madlittlemods/11025-fix-user-directory-th…

    …rowing-exception-when-interacting-with-appservice-sender
    MadLittleMods committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    1dea46b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a92cad8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6523234 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8d2025c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Add test covering appservice sender joining a room

    I don't think this actually improves coverage as such, but I'll sleep
    better at night having this case checked!
    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    ff6212a View commit details
    Browse the repository at this point in the history
  2. On reflection, INCLUDE the appservice senders

    That's the current behaviour (I didn't realise they typically don't
    match their own user regex).
    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    3c053fd View commit details
    Browse the repository at this point in the history
  3. Update changelog

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    1b84f7d View commit details
    Browse the repository at this point in the history
  4. Update tests

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    03db1e5 View commit details
    Browse the repository at this point in the history
  5. Lint

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4c5afd0 View commit details
    Browse the repository at this point in the history
  6. Ensure dir rebuild includes appservice senders

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    7648898 View commit details
    Browse the repository at this point in the history
  7. Desperate attempt to make test pass on CI. It's fine locally!

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    8550c0a View commit details
    Browse the repository at this point in the history
  8. Please do dump logs

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    04078ff View commit details
    Browse the repository at this point in the history
  9. Fix typo

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    9fec1cc View commit details
    Browse the repository at this point in the history