Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Extract _resolve_state_at_missing_prevs #10624

Merged
merged 8 commits into from
Aug 19, 2021
Merged

Extract _resolve_state_at_missing_prevs #10624

merged 8 commits into from
Aug 19, 2021

Commits on Aug 18, 2021

  1. Extract _resolve_state_at_missing_prevs method 

    This was done with Pycharm's "extract method"
    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    88f3559 View commit details
    Browse the repository at this point in the history

  2. remove dead comment

    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    bd35f2a View commit details
    Browse the repository at this point in the history

  3. Remove some parameters from _resolve_state_at_missing_prevs 

    Most of these parameters are easy to calculate.
    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    85e5df8 View commit details
    Browse the repository at this point in the history

  4. Reorder sent_to_us_directly/missing_prevs conditions 

    These should be equivalent
    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    2b487de View commit details
    Browse the repository at this point in the history

  5. Push down if not missing_prevs condition

    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    cfb347a View commit details
    Browse the repository at this point in the history

  6. Type annotations and docstrings for _resolve_state_at_missing_prevs

    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    9885bdf View commit details
    Browse the repository at this point in the history

  7. Push down missing_prevs calculation 

    No point calculating this unless we need it.
    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    67ea6b4 View commit details
    Browse the repository at this point in the history

  8. changelog

    @richvdh
    richvdh committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    177a8ad View commit details
    Browse the repository at this point in the history