Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Port the PresenceRouter module interface to the new generic interface #10524

Merged
merged 15 commits into from
Aug 17, 2021
Merged

Port the PresenceRouter module interface to the new generic interface #10524

merged 15 commits into from
Aug 17, 2021

Commits on Aug 4, 2021

  1. Moved presence_router to use new callback registering pattern 

    load_legacy_presence_router loads a presence router configured
the old way (as opposed to in the modules config section)
    Azrenbeth authored and Azrenbeth committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    bb0f520 View commit details
    Browse the repository at this point in the history

  2. Updated presence router tests 

    The same test bodies used to test two modules, one configured
with the legacy style, and the other with the new style
    Azrenbeth authored and Azrenbeth committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    ca24345 View commit details
    Browse the repository at this point in the history

  3. old config style no longer appears in sample_config

    Azrenbeth authored and Azrenbeth committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    9aef9fb View commit details
    Browse the repository at this point in the history

  4. Updated docs with information on presence_router callbacks

    Azrenbeth authored and Azrenbeth committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    3d71c76 View commit details
    Browse the repository at this point in the history

  5. Added changelog

    Azrenbeth authored and Azrenbeth committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    54e7e05 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Undid changes to legacy presence router module docs 

    Have replaced with a deprecation notice at the top
like was done with spam checkers
    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    54ca937 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Brendan Abolivier <[email protected]>
    @Azrenbeth @babolivier
    Azrenbeth and babolivier authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    2c68a91 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Applied suggestions from code review

    Azrenbeth authored and Azrenbeth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    b9a69b7 View commit details
    Browse the repository at this point in the history

  2. Added error handling when calling callbacks 

    Also renamed the callback types to the form
of XYZ_CALLBACK
    Azrenbeth authored and Azrenbeth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    8fb5363 View commit details
    Browse the repository at this point in the history

  3. Moved type check to after ALL_USERS check 

    removed now unneeded combine function
    Azrenbeth authored and Azrenbeth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    9689e58 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Added suggestions from code reivew

    Azrenbeth authored and Azrenbeth committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    816e422 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into azren/presence_router_to_new_module_system

    Azrenbeth authored and Azrenbeth committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    b86de75 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Added newline and moved constant to __all__

    Azrenbeth authored and Azrenbeth committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    6af5c18 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into azren/presence_router_to_new_module_system

    Azrenbeth authored and Azrenbeth committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    c56d9c3 View commit details
    Browse the repository at this point in the history

  3. Applied suggestions from code review

    Azrenbeth authored and Azrenbeth committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    6e27e01 View commit details
    Browse the repository at this point in the history