This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Refactor the checking restricted join rules #10009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
May 18, 2021
| ) | ||
| return result | ||
|
|
||
| async def is_user_in_rooms(self, room_ids: Collection[str], user_id: str) -> bool: |
There was a problem hiding this comment.
I couldn't find a method on any of the handlers / stores that lets you check if a user is in a room already, arguably this might be better on the RoomMemberHandler or something, but it is convenient for the EventAuthHandler to have no dependencies.
|
Thanks for this, it was actually helpful seeing it split up. I ended up referring back to #9922 to figure out how it was used in other places so I ended up just leaving comments there instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another bit split out of #9922 and builds on #10007. This performs the refactoring used by #9922 in the
EventAuthHandlerseparately.