Synapse failed to process uploaded images with python-pillow 10.0.0 #15873

Kimiblock · 2023-07-04T10:58:40Z

Description

When I'm trying to upload an image to a federated room or update the avatar of a room, synapse fails to process the image.

Steps to reproduce

Open Element.
Try to update any room avatar.

Homeserver

chat.kimiblock.top

Synapse Version

1.85.2

Installation Method

Other (please mention below)

Database

Single PostgreSQL, never restored any backup nor ported from SQLite.

Workers

Single process

Platform

Running synapse on Arch Linux with PostgreSQL. System is up to date.

Using package postgresql 15.3-2 matrix-synapse 1.85.2-1 from Arch's official repos.

Configuration

Configurations related to media and messages:

media_store_path: "/mnt/main/Cache/SynapseData"
media_storage_providers:
  - module: file_system
    store_local: true
    store_remote: true
    store_synchronous: true
    config:
        directory: /mnt/main/Cache/SynapseData/media-storage
max_image_pixels: 108M
media_retention:
    local_media_lifetime: 4d
    remote_media_lifetime: 1d

max_upload_size: 100M

max_avatar_size: 10M
retention:
    enabled: true
    default_policy:
        min_lifetime: 90d
        max_lifetime: 180d
        allowed_lifetime_min: 90d
        allowed_lifetime_max: 180d

Relevant log output

Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]: 2023-07-04 18:45:18,152 - synapse.media.media_repository - 204 - INFO - POST-1438 - Stored local media in file '/mnt/main/Cache/SynapseData/local_content/ck/qF/AEGVQmRDqPDZMWxZhEKe'
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]: 2023-07-04 18:45:18,185 - synapse.http.server - 130 - ERROR - POST-1438 - Failed handle request via 'UploadResource': <XForwardedForRequest at 0x55d8caaa1250 method='POST' uri='/_matrix/media/r0/upload?filename=annoucement.png' clientproto='HTTP/1.1' site='61145'>
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]: Traceback (most recent call last):
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/http/server.py", line 313, in _async_render_wrapper
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     callback_return = await self._async_render(request)
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/http/server.py", line 343, in _async_render
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     callback_return = await raw_callback_return
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:                       ^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/rest/media/upload_resource.py", line 96, in _async_render_POST
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     content_uri = await self.media_repo.create_content(
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/media/media_repository.py", line 215, in create_content
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     await self._generate_thumbnails(None, media_id, media_id, media_type)
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/media/media_repository.py", line 797, in _generate_thumbnails
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     t_byte_source = await defer_to_thread(
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:                     ^^^^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/twisted/python/threadpool.py", line 244, in inContext
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     result = inContext.theWork()  # type: ignore[attr-defined]
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:              ^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/twisted/python/threadpool.py", line 260, in <lambda>
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     inContext.theWork = lambda: context.call(  # type: ignore[attr-defined]
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/twisted/python/context.py", line 117, in callWithContext
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     return self.currentContext().callWithContext(ctx, func, *args, **kw)
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/twisted/python/context.py", line 82, in callWithContext
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     return func(*args, **kw)
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:            ^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/logging/context.py", line 969, in g
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     return f(*args, **kwargs)
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:            ^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/media/thumbnailer.py", line 172, in crop
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     with self._resize(scaled_width, scaled_height) as scaled_image:
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:   File "/usr/lib/python3.11/site-packages/synapse/media/thumbnailer.py", line 134, in _resize
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:     return self.image.resize((width, height), Image.ANTIALIAS)
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]:                                               ^^^^^^^^^^^^^^^
Jul 04 18:45:18 serverOS-kimiblock.top synapse[71156]: AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

Anything else that would be useful to know?

It was working properly until I restarted synapse today.

Sending images in a room seems to be working fine.

The text was updated successfully, but these errors were encountered:

Kimiblock · 2023-07-04T11:13:21Z

Seems like Arch updated python-pillow today and synapse is not playing well with Pillow 10.0.0

[2023-07-04T11:47:30+0800] [ALPM] upgraded python-pillow (9.5.0-2 -> 10.0.0-1)

I've downgraded python-pillow to 9.5.0-2 and the issue is gone.

Kimiblock · 2023-07-04T11:39:56Z

Reopen this issue.

https://github.com/python-pillow/Pillow/blob/be828f4d62b3802733a8fac6b6b59cced2092696/docs/deprecations.rst#constants

(Link provided by q234rty)

RhinoDevel · 2023-07-04T12:46:05Z

Seems like Arch updated python-pillow today and synapse is not playing well with Pillow 10.0.0
[2023-07-04T11:47:30+0800] [ALPM] upgraded python-pillow (9.5.0-2 -> 10.0.0-1)
I've downgraded python-pillow to 9.5.0-2 and the issue is gone.

In case anyone else is wondering how to downgrade with pip (e.g. from the virtual environment):

pip install 'Pillow<=9.5.0-2'

an0nfunc · 2023-07-04T12:58:54Z

Replacing this line

synapse/synapse/media/thumbnailer.py

Line 134 in 670d590

return self.image.resize((width, height), Image.ANTIALIAS)

with

return self.image.resize((width, height), Image.LANCZOS)

fixes this. For fellow arch users, that is in /usr/lib/python3.11/site-packages/synapse/media/thumbnailer.py line 134.

ANTIALIAS has been renamed a long time ago.

clokep · 2023-07-04T14:21:54Z

Would you mind making a PR?

an0nfunc · 2023-07-04T15:21:24Z

Done. Ignore the first one, not sure why GitHub decided to open the PR against my own fork 😮‍💨 .

Pillow 10 removes some deprecated constatns that are used in synapse, the issue is already fixed in upstream, see [1,2]. Moreover, synapse is incompatible with pydantic 2.0 [3]. [1] matrix-org/synapse#15873 [2] matrix-org/synapse#15876 [3] matrix-org/synapse#15858 Closes: https://bugs.gentoo.org/909644 Signed-off-by: Petr Vaněk <[email protected]>

Pillow 10 removes some deprecated constatns that are used in synapse, the issue is already fixed in upstream, see [1,2]. Moreover, synapse is incompatible with pydantic 2.0 [3]. [1] matrix-org/synapse#15873 [2] matrix-org/synapse#15876 [3] matrix-org/synapse#15858 Closes: https://bugs.gentoo.org/909644 Signed-off-by: Petr Vaněk <[email protected]> Signed-off-by: Sam James <[email protected]>

Kimiblock closed this as completed Jul 4, 2023

Kimiblock reopened this Jul 4, 2023

Kimiblock changed the title ~~Synapse failed to process uploaded images: AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'~~ Synapse failed to process uploaded images with python-pillow 10.0.0 Jul 4, 2023

This was referenced Jul 4, 2023

Use Image.LANCZOS instead of Image.ANTIALIAS to resize thumbnails an0nfunc/synapse#1

Closed

use Image.LANCZOS instead of Image.ANTIALIAS for thumbnail resize #15876

Merged

MatMaul closed this as completed in #15876 Jul 5, 2023

csett86 mentioned this issue Jul 9, 2023

Can’t preview and post images luki-ev/synod-ios#2

Closed

dklimpel mentioned this issue Jul 9, 2023

Unable to upload profile picture (Internal Server Error) #15895

Closed

DMRobertson mentioned this issue Jul 10, 2023

Debian 12, Pillow 10: thumbnailer.py throws "AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS' " #15914

Closed

clokep mentioned this issue Jul 12, 2023

Failed to upload Images running pyllow 10.0 #15915

Closed

dklimpel mentioned this issue Jul 14, 2023

Pillow 10.0.0 slows down images uploading speeds #15937

Closed

DMRobertson mentioned this issue Jul 24, 2023

Bump pillow from 9.4.0 to 10.0.0 #15986

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Synapse failed to process uploaded images with python-pillow 10.0.0 #15873

Synapse failed to process uploaded images with python-pillow 10.0.0 #15873

Kimiblock commented Jul 4, 2023 •

edited

Loading

Kimiblock commented Jul 4, 2023

Kimiblock commented Jul 4, 2023

RhinoDevel commented Jul 4, 2023

an0nfunc commented Jul 4, 2023 •

edited

Loading

clokep commented Jul 4, 2023

an0nfunc commented Jul 4, 2023 •

edited

Loading

Synapse failed to process uploaded images with python-pillow 10.0.0 #15873

Synapse failed to process uploaded images with python-pillow 10.0.0 #15873

Comments

Kimiblock commented Jul 4, 2023 • edited Loading

Description

Steps to reproduce

Homeserver

Synapse Version

Installation Method

Database

Workers

Platform

Configuration

Relevant log output

Anything else that would be useful to know?

Kimiblock commented Jul 4, 2023

Kimiblock commented Jul 4, 2023

RhinoDevel commented Jul 4, 2023

an0nfunc commented Jul 4, 2023 • edited Loading

clokep commented Jul 4, 2023

an0nfunc commented Jul 4, 2023 • edited Loading

Kimiblock commented Jul 4, 2023 •

edited

Loading

an0nfunc commented Jul 4, 2023 •

edited

Loading

an0nfunc commented Jul 4, 2023 •

edited

Loading