Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Read receipts on element web are broken #12669

Closed
erikjohnston opened this issue May 9, 2022 · 0 comments · Fixed by #12670
Closed

Read receipts on element web are broken #12669

erikjohnston opened this issue May 9, 2022 · 0 comments · Fixed by #12670
Assignees
Labels
S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release

Comments

@erikjohnston
Copy link
Member

erikjohnston commented May 9, 2022

Broke by #12168. Element web sends a hidden read receipt type, which Synapse doesn't understand and so 400s:

if set(body.keys()) > valid_receipt_types:
raise SynapseError(
400,
"Receipt type must be 'm.read', 'org.matrix.msc2285.read.private' or 'm.fully_read'"
if self.config.experimental.msc2285_enabled
else "Receipt type must be 'm.read' or 'm.fully_read'",
)

This is a problem as it stops the other receipt types from being persisted.

We shouldn't be denying unknown receipt types.

@erikjohnston erikjohnston added S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release labels May 9, 2022
@erikjohnston erikjohnston self-assigned this May 9, 2022
erikjohnston added a commit that referenced this issue May 9, 2022
@DMRobertson DMRobertson added the X-Regression Something broke which worked on a previous release label May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants