This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
followup on asynchronous-federation work #10275
Comments
matrix-org/sytest#1059 fixes one of the tests. |
This also seems to be causing a complement test to fail: |
This comment has been minimized.
This comment has been minimized.
This was referenced Jun 30, 2021
matrix-org/complement#142 updates complement to match the sytest blacklist applied in #10272. |
4 tasks
callahad
added
P1
P3
(OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches
and removed
P1
labels
Jul 1, 2021
richvdh
added a commit
to matrix-org/complement
that referenced
this issue
Jul 8, 2021
…r room version 6' We can't assume that homeservers will process inbound federation events synchronously. In this particular case we replace the check for errors in /send response with a check that if we send a new event that references the expected rejected event we'll see a request for that event come in. c.f. matrix-org/synapse#10275
richvdh
added a commit
to matrix-org/complement
that referenced
this issue
Jul 9, 2021
…r room version 6' (#152) This test got blacklisted for the release of Synapse 1.37.1. We can't assume that homeservers will process inbound federation events synchronously. In this particular case we replace the check for errors in /send response with a check that if we send a new event that references the expected rejected event we'll see a request for that event come in. c.f. matrix-org/synapse#10275 and matrix-org/sytest#1061
This was referenced Jul 9, 2021
erikjohnston
added
the
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
label
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A few things it might be good to think about having landed #10272:
Outbound federation will ignore a missing event with bad JSON for room version 6
Re-enable room v6 sytest #10345
Backfilled events whose prev_events are in a different room do not allow cross-room back-pagination
Reenable 'Backfilled events whose prev_events...' sytest #10292
Federation rejects inbound events where the prev_events cannot be found
Unblacklist fixed tests #10357
Outbound federation will ignore a missing event with bad JSON for room version 6
Fix 'Outbound federation will ignore a missing event with bad JSON for room version 6' complement#152
room_queues
inFederationHandler
. I think we should update that code to use the same logic. (parking this for now - we'll revisit it as part of future join work)We now only process one event per room at a time.Not expected to be significantThe text was updated successfully, but these errors were encountered: