Fix duplicate logging of exceptions in transaction processing (#9780)

There's no point logging this twice.
matrix-org · Apr 9, 2021 · f946450 · f946450
1 parent abc814d
commit f946450
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/changelog.d/9780.bugfix b/changelog.d/9780.bugfix
@@ -0,0 +1 @@
+Fix duplicate logging of exceptions thrown during federation transaction processing.
diff --git a/synapse/federation/transport/server.py b/synapse/federation/transport/server.py
@@ -425,13 +425,9 @@ async def on_PUT(self, origin, content, query, transaction_id):
             logger.exception(e)
             return 400, {"error": "Invalid transaction"}
 
-        try:
-            code, response = await self.handler.on_incoming_transaction(
-                origin, transaction_data
-            )
-        except Exception:
-            logger.exception("on_incoming_transaction failed")
-            raise
+        code, response = await self.handler.on_incoming_transaction(
+            origin, transaction_data
+        )
 
         return code, response