Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Speed up purge room by adding index (#16657)
Browse files Browse the repository at this point in the history
What it says on the tin
  • Loading branch information
erikjohnston authored Nov 17, 2023
1 parent 6fec2d0 commit 9c02ef2
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/16657.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Speed up purge room by adding an index to `event_push_summary`.
8 changes: 8 additions & 0 deletions synapse/storage/databases/main/event_push_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,14 @@ def __init__(
self._background_drop_null_thread_id_indexes,
)

# Add a room ID index to speed up room deletion
self.db_pool.updates.register_background_index_update(
"event_push_summary_index_room_id",
index_name="event_push_summary_index_room_id",
table="event_push_summary",
columns=["room_id"],
)

async def _background_drop_null_thread_id_indexes(
self, progress: JsonDict, batch_size: int
) -> int:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/* Copyright 2023 The Matrix.org Foundation C.I.C
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(8306, 'event_push_summary_index_room_id', '{}');

0 comments on commit 9c02ef2

Please sign in to comment.