Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Better error message when failing to request from another process (#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
erikjohnston authored Feb 22, 2022
1 parent 250104d commit 6d14b3d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/12060.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix error message when a worker process fails to talk to another worker process.
4 changes: 3 additions & 1 deletion synapse/replication/http/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,9 @@ async def send_request(*, instance_name: str = "master", **kwargs: Any) -> Any:
raise e.to_synapse_error()
except Exception as e:
_outgoing_request_counter.labels(cls.NAME, "ERR").inc()
raise SynapseError(502, "Failed to talk to main process") from e
raise SynapseError(
502, f"Failed to talk to {instance_name} process"
) from e

_outgoing_request_counter.labels(cls.NAME, 200).inc()
return result
Expand Down

0 comments on commit 6d14b3d

Please sign in to comment.