Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Log stack traces when a missing opentracing span is detected (#10983)
Browse files Browse the repository at this point in the history
Make it easier to track down where opentracing spans are going missing
by including stack traces in the logs.
  • Loading branch information
squahtx authored Oct 5, 2021
1 parent eda8c88 commit 660c8c1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/10983.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Log stack traces when a missing opentracing span is detected.
1 change: 1 addition & 0 deletions synapse/logging/opentracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ def ensure_active_span_inner_2(*args, **kwargs):
"There was no active span when trying to %s."
" Did you forget to start one or did a context slip?",
message,
stack_info=True,
)

return ret
Expand Down

0 comments on commit 660c8c1

Please sign in to comment.