Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
As an optimisation, use TRUNCATE on Postgres when clearing the user…
Browse files Browse the repository at this point in the history
… directory tables. (#15316)
  • Loading branch information
reivilibre authored Mar 24, 2023
1 parent 5b70f24 commit 5f7c908
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
1 change: 1 addition & 0 deletions changelog.d/15316.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
As an optimisation, use `TRUNCATE` on Postgres when clearing the user directory tables.
15 changes: 11 additions & 4 deletions synapse/storage/databases/main/user_directory.py
Original file line number Diff line number Diff line change
Expand Up @@ -698,10 +698,17 @@ async def delete_all_from_user_dir(self) -> None:
"""Delete the entire user directory"""

def _delete_all_from_user_dir_txn(txn: LoggingTransaction) -> None:
txn.execute("DELETE FROM user_directory")
txn.execute("DELETE FROM user_directory_search")
txn.execute("DELETE FROM users_in_public_rooms")
txn.execute("DELETE FROM users_who_share_private_rooms")
# SQLite doesn't support TRUNCATE.
# On Postgres, DELETE FROM does a table scan but TRUNCATE is more efficient.
truncate = (
"DELETE FROM"
if isinstance(self.database_engine, Sqlite3Engine)
else "TRUNCATE"
)
txn.execute(f"{truncate} user_directory")
txn.execute(f"{truncate} user_directory_search")
txn.execute(f"{truncate} users_in_public_rooms")
txn.execute(f"{truncate} users_who_share_private_rooms")
txn.call_after(self.get_user_in_directory.invalidate_all)

await self.db_pool.runInteraction(
Expand Down

0 comments on commit 5f7c908

Please sign in to comment.