Disable push rule evaluation for rooms excluded from sync (#15361)

* no push for excluded room from sync * add changelog Signed-off-by: Maghen Calinghee <[email protected]> * correct changelog
matrix-org · Apr 27, 2023 · 486c059 · 486c059
1 parent 3e95c19
commit 486c059
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/changelog.d/15361.bugfix b/changelog.d/15361.bugfix
@@ -0,0 +1 @@
+Disable push rule evaluation for rooms excluded from sync.
diff --git a/synapse/push/bulk_push_rule_evaluator.py b/synapse/push/bulk_push_rule_evaluator.py
@@ -326,6 +326,7 @@ async def _action_for_event_by_user(
         if (
             not event.internal_metadata.is_notifiable()
             or event.internal_metadata.is_historical()
+            or event.room_id in self.hs.config.server.rooms_to_exclude_from_sync
         ):
             # Push rules for events that aren't notifiable can't be processed by this and
             # we want to skip push notification actions for historical messages