Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate payload for redacting state #359

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

DMRobertson
Copy link
Contributor

Part of #294.

I want to use V2InvalidateRoom to mean "gappy poll received, reload everything about the room and nuke all involved users' connections", so we can finally land #329 (or equivalent).

We already use this payload to mean "a piece of room state got redacted". In this situation we only need to reload the global cache; we don't need to nuke connections. Room state redactions happen rarely (we think) so we could get away with reusing V2InvalidateRoom for this case too. But

  • it would be nice to avoid giving M_UNKNOWN_POS to clients where we can.
  • ne'er-do-wells could abuse this by redacting their own state events in order to nuke connections. (AFAICS the default power levels do not impose a PL requirement for m.room.redaction.)

So that we don't end up nuking conns unnecessarily.
@DMRobertson DMRobertson marked this pull request as ready for review November 1, 2023 19:54
@DMRobertson DMRobertson merged commit 0e8d4a8 into main Nov 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants