Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress duplicate account data events #237

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Suppress duplicate account data events #237

merged 5 commits into from
Aug 2, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Aug 2, 2023

With regression test.

Fixes #189

@kegsay kegsay added bug Something isn't working poller labels Aug 2, 2023
@kegsay kegsay requested a review from DMRobertson August 2, 2023 10:50
DMRobertson
DMRobertson approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's still possible for a really slow poller to break this. But I think that is a) unlikely and b) beyond our control, with no kind of timestamp or ordering available. LGTM.

@kegsay
Copy link
Member Author

kegsay commented Aug 2, 2023

A really slow poller can cause needless account data events to come through which will reset the value, but they will eventually converge on the correct value.

@kegsay kegsay mentioned this pull request Aug 2, 2023
Closed
@kegsay kegsay merged commit 2d19d68 into main Aug 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working poller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

account_data returned by /_matrix/client/unstable/org.matrix.msc3575/sync are sometimes inconsistent
2 participants
@kegsay @DMRobertson