Do not make snapshots for lone leave events #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically this is targetting invite rejections, where the leave event is inside the leave block of the sync v2 response. Previously, we would make a snapshot with this leave event. If the proxy wasn't in this room, it would mean the room state would just be the leave event, which is wrong. If the proxy was in the room, then state would correctly be rolled forward.
DMRobertson
reviewed
Aug 1, 2023
DMRobertson
reviewed
Aug 1, 2023
DMRobertson
reviewed
Aug 1, 2023
DMRobertson
reviewed
Aug 1, 2023
DMRobertson
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Seems sane. Is this worth an integration test? Something like
- be invited to unknown public room
- reject invite
- check nothing in the snapshots table with that room ID
- join said room
- check you get sensible state down /sync
- check there is exactly one snapshot for that room ID? (except you might get more if the timeline has state events)
DMRobertson
approved these changes
Aug 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically this is targetting invite rejections, where the leave event is inside the leave block of the sync v2 response.
Previously, we would make a snapshot with this leave event. If the proxy wasn't in this room, it would mean the room state would just be the leave event, which is wrong. If the proxy was in the room, then state would correctly be rolled forward.