Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift and document indexing heap size #8

Closed
jryans opened this issue Nov 5, 2019 · 0 comments
Closed

Lift and document indexing heap size #8

jryans opened this issue Nov 5, 2019 · 0 comments

Comments

@jryans
Copy link
Contributor

jryans commented Nov 5, 2019

When getting an index writer, there is a magic number for the amount of heap that Tantivy should use:

seshat/src/index.rs

Lines 217 to 227 in 71e17fa

pub fn get_writer(&self) -> Result<Writer, tv::Error> {
Ok(Writer {
inner: self.index.writer(50_000_000)?,
body_field: self.body_field,
topic_field: self.topic_field,
name_field: self.name_field,
event_id_field: self.event_id_field,
room_id_field: self.room_id_field,
})
}
}

It be nice to make this value more prominent at the top of the file (or similar) with a comment explaining how it was determined.

poljar added a commit that referenced this issue Nov 6, 2019
poljar added a commit that referenced this issue Nov 6, 2019
@poljar poljar closed this as completed in 4ce88eb Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant