Replace shutdown_room API with DELETE /_synapse/admin/v1/rooms/<room_… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not clear how I can test it. |
This was referenced Jul 28, 2021
|
@Yoric has promised we can get this deployed in the week of 2021/08/09. |
turt2live
requested changes
Aug 5, 2021
src/Mjolnir.ts
Outdated
| new_room_user_id: await this.client.getUserId(), | ||
| block: true, | ||
| message: message || "This room was shutdown by a moderator" |
There was a problem hiding this comment.
we should exclude the message so we can continue using the default
There was a problem hiding this comment.
I don't understand this comment. Should I remove "This room was shutdown by a moderator"?
There was a problem hiding this comment.
yea, just so the default message from Synapse can be used.
package.json
Outdated
Comment on lines
17
to
25
| "@types/mocha": "^8.2.2", | ||
| "@types/node": "11", | ||
| "@types/mocha": "^9.0.0", | ||
| "@types/node": "^16.4.5", | ||
| "eslint": "^7.31.0", | ||
| "expect": "^27.0.6", | ||
| "mocha": "^9.0.1", | ||
| "ts-mocha": "^8.0.0", | ||
| "tslint": "^6.1.3", | ||
| "typescript": "^4.3.5" | ||
| "typescript": "^4.3.5", | ||
| "typescript-formatter": "^7.2.2" |
There was a problem hiding this comment.
These changes appear unrelated
…id> - Resolves #76, closes #96 As per matrix-org/synapse#9052, shutdown_room is going away, to be replaced with DELETE /_synapse/admin/v1/rooms/<room_id>.
Yoric
force-pushed
the
yoric/delete-rooms-api
branch
from
93547a7
to
6874f73
Compare
Yoric
force-pushed
the
yoric/delete-rooms-api
branch
from
6874f73
to
b60f503
Compare
…without a message
turt2live
approved these changes
Aug 17, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…id> - Resolves #76, closes #96
As per matrix-org/synapse#9052, shutdown_room is going away, to be replaced with DELETE /_synapse/admin/v1/rooms/<room_id>.