Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Synapse 1.73 blog post #1587

Merged
merged 8 commits into from
Dec 8, 2022
Merged

Add Synapse 1.73 blog post #1587

merged 8 commits into from
Dec 8, 2022

Conversation

MatMaul
Copy link

@MatMaul MatMaul commented Dec 7, 2022 •
edited by github-actions bot
Loading

@MatMaul MatMaul marked this pull request as ready for review December 7, 2022 16:52
@babolivier babolivier self-requested a review December 7, 2022 16:56
babolivier
babolivier suggested changes Dec 7, 2022
View reviewed changes
Copy link

@babolivier babolivier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rephrasing. In general I think it's best to keep a neutral tone, and to avoid addressing the reader too directly (I try to avoid the use of "you", etc), but ymmv.

gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
babolivier
babolivier suggested changes Dec 8, 2022
View reviewed changes
Copy link

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good now!

gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
babolivier
babolivier approved these changes Dec 8, 2022
View reviewed changes
Copy link

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart for those two points!

gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
gatsby/content/blog/2022/12/2022-12-07-synapse-1.73.mdx Outdated Show resolved Hide resolved
@MatMaul @babolivier
Apply suggestions from code review
9ba8c46 
Co-authored-by: Brendan Abolivier <[email protected]>
@MatMaul MatMaul merged commit f7da208 into master Dec 8, 2022
@MatMaul MatMaul deleted the mv/synapse-1.73 branch December 8, 2022 11:29
@MatMaul
Copy link
Author

MatMaul commented Dec 8, 2022 •
edited
Loading

Thanks all for the reviews.

@rumpelsepp rumpelsepp mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MTRNord MTRNord MTRNord left review comments

@MadLittleMods MadLittleMods MadLittleMods left review comments

@babolivier babolivier babolivier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatMaul @MadLittleMods @MTRNord @babolivier