Use DisabledComposerView instead of no composer to add message
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
added a commit
to element-hq/hydrogen-web
that referenced
this pull request
Aug 30, 2022
…`DisabledComposerView` Changes for matrix-org/matrix-viewer#54
Conflicts: shared/4-hydrogen-vm-render-script.js
MadLittleMods
added a commit
to element-hq/hydrogen-web
that referenced
this pull request
Aug 31, 2022
Changes used in matrix-org/matrix-viewer#54 so we can add a link.
MadLittleMods
added a commit
that referenced
this pull request
Aug 31, 2022
…changes (#58) We added the description in #54 but then made a fix to one of the after render errors, #57, which exposed that the description is then overriden when the powerlevel changes. We now just override the getters directly instead of the internal fields which are overwritten internally. --- This also fixes a warning from Hydrogen in the console: ``` disposable not found, did it leak? {kind: 'disabled', description: Array(3)} ```
MadLittleMods
added
the
A-archive-room-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
DisabledComposerViewinstead of no composer to add message:Also refactors some of the
viewsandviewmodelsout to their own filesTodo
@mlm/hydrogen-view-sdkso it includes the changes from Draft: Scratch changes formatrix-public-archiveelement-hq/hydrogen-web#653