MSC4151: Reporting rooms #1938
Open
MSC4151: Reporting rooms #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <[email protected]>
Johennes
commented
Aug 26, 2024
| @@ -5,9 +5,6 @@ Users may encounter content which they find inappropriate and should be | |||
| able to report it to the server administrators or room moderators for | |||
| review. This module defines a way for users to report content. | |||
|
|
|||
| Content is reported based upon a negative score, where -100 is "most | |||
| offensive" and 0 is "inoffensive". | |||
|
|
|||
There was a problem hiding this comment.
I removed this here because it only applies to event reporting and is repeated in the corresponding endpoint's documentation.
Johennes
commented
Aug 26, 2024
| properties: | ||
| reason: | ||
| type: string | ||
| description: The reason the room is being reported. |
Johennes
commented
Aug 26, 2024
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: definitions/errors/rate_limited.yaml |
There was a problem hiding this comment.
I'm not sure if this is technically correct since the MSC strongly recommends but doesn't require rate limiting.
Johennes
commented
Aug 26, 2024
| @@ -29,7 +92,7 @@ paths: | |||
| will require the homeserver to check whether a user is joined to | |||
| the room. To combat this, homeserver implementations should add | |||
| a random delay when generating a response. | |||
| operationId: reportContent | |||
| operationId: reportEvent | |||
There was a problem hiding this comment.
I'm unsure what consequences changing this has but the old ID felt unsuitable now that there are two endpoints in the module.
Johennes
commented
Aug 26, 2024
| @@ -62,7 +125,7 @@ paths: | |||
| and 0 is inoffensive. | |||
| reason: | |||
| type: string | |||
| description: The reason the content is being reported. May be blank. | |||
| description: The reason the content is being reported. | |||
There was a problem hiding this comment.
I have removed this as proposed in MSC2414 and thought it aligns well enough with the rest of this pull request to sneak in. 😇
Johennes
commented
Aug 27, 2024
Johennes
commented
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per matrix-org/matrix-spec-proposals#4151.
The MSC proposed that clients should hide reported rooms. However, there isn't any API for ignoring rooms yet. So I left that part out of the spec as otherwise clients would have to invent a system for doing this across devices.
Pull Request Checklist
Preview: https://pr1938--matrix-spec-previews.netlify.app