Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 403 error response to federation/v1/state_ids #1926

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add 403 error response to federation/v1/state_ids #1926

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99e0ba4
#1912 issue : Update events.yaml
AllMightLegend Aug 12, 2024
b7413ff
Create 1926.feature
AllMightLegend Aug 12, 2024
b7ae765
Rename changelogs/server_server/1926.feature to changelogs/server_ser…
AllMightLegend Aug 12, 2024
bc18d37
Update and rename 1926.feature to 1926.new
AllMightLegend Aug 13, 2024
a8224c7
Update 1926.new
AllMightLegend Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions changelogs/server_server/newsfragments/1926.new
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
RESPONSE/server-server/edu.yaml

Fixes issue #1912 by adding error response to /_matrix/federation/v1/state_ids/{roomId}

CONTENT :
"403":
description: |-
The host is not in the room or the host is banned from the room via its ACL.
content:
application/json:
schema:
$ref: ../client-server/definitions/errors/error.yaml
examples:
response:
value: {
"errcode": "M_FORBIDDEN",
"error": "You do not have permission to access the state at the requested event."
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the rendered output of this PR:

image

This is not a useful changelog entry.

Please have a look at other changelog fragments, as well as the existing changelog, for examples of what might be appropriate here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes give me a bit of time I will definitely complete it . Can you also please give me a heads up about why the output is like this and a little bit information about changelog fragments ? Appreciate your help sir

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked at other examples? Start there. If you still have questions, come back.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thank you sir

13 changes: 13 additions & 0 deletions data/api/server-server/events.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,19 @@ paths:
required:
- auth_chain_ids
- pdu_ids
"403":
description: |-
The host is not in the room or the host is banned from the room via its ACL.
content:
application/json:
schema:
$ref: ../client-server/definitions/errors/error.yaml
examples:
response:
value: {
"errcode": "M_FORBIDDEN",
"error": "You do not have permission to access the state at the requested event."
}
"404":
description: |-
The given `event_id` was not found or the server doesn't know about the state at
Expand Down