Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out non-JSON request/response content types as tables #1756

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Mar 19, 2024

Currently we display this as a table like "image/png|image/jpeg" and description on a single line, but we're using a table. This breaks the join out to individual rows.

See /client-server-api/#get_matrixmediav3thumbnailservernamemediaid and /client-server-api/#post_matrixmediav3upload for examples.

Preview: https://pr1756--matrix-spec-previews.netlify.app

Currently we display this as a table like "image/png|image/jpeg" and description on a single line, but we're using a table. This breaks the join out to individual rows.
@turt2live turt2live requested a review from a team as a code owner March 19, 2024 19:58
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't visually see a difference for /client-server-api/#post_matrixmediav3upload, but /client-server-api/#get_matrixmediav3thumbnailservernamemediaid is a marked improvement.

Thank you!

@turt2live
Copy link
Member Author

hmm, good point on /upload: it has a request body table, but only one type 🤦
image

@turt2live turt2live merged commit eb22fac into main Mar 21, 2024
12 checks passed
@turt2live turt2live deleted the travis/content-types branch March 21, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants