Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify MSC3882: Using an existing session to log in another #1530

Merged
merged 7 commits into from
May 23, 2023

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented May 19, 2023

@turt2live turt2live added the release-blocker Blocks the next release from happening label May 19, 2023
@turt2live turt2live marked this pull request as ready for review May 19, 2023 04:11
@turt2live turt2live requested a review from a team as a code owner May 19, 2023 04:11
@turt2live turt2live requested review from dbkr and richvdh May 19, 2023 04:12
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise

@@ -0,0 +1 @@
[`POST /_matrix/client/v3/login/get_token`](/client-server-api/#post_matrixclientv3loginget_token).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of this type of newsfragment being a thing. We have other new endpoints (POST /_matrix/media/v1/create etc) which haven't had one of these...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea... They'll be caught as part of "changelog normalization" in the release process.

data/api/client-server/login.yaml Outdated Show resolved Hide resolved
data/api/client-server/login.yaml Outdated Show resolved Hide resolved
data/api/client-server/login.yaml Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from richvdh May 19, 2023 18:34
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

changelogs/client_server/newsfragments/1530.new Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker Blocks the next release from happening
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants