Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to documentation style #1456

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Minor updates to documentation style #1456

merged 1 commit into from
Feb 28, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Feb 28, 2023

@richvdh richvdh requested a review from a team as a code owner February 28, 2023 15:14
Comment on lines +75 to +79
* "i.e." (*id est*) is an abbreviation and hence is written with two full
stops. Prefer full sentences where possible without loss of clarity.

* Prefer "for example" over "e.g.". If you *must* use "e.g.", remember it too
is an abbreviation (*exempli gratia*).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying over some comments from #1424 (comment):

@turt2live says:

... I'm not currently convinced it's a thing we [should] do - given the first point is that the language should be unambiguous, shouldn't we be using complete words/sentences instead? ("For example", "As demonstrated below", "..., such as when", etc)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree in principle, and certainly "for example" is generally preferable to "e.g". I have worded this accordingly.

i.e. is really handy and doesn't have a direct analogue: although its literal translation is "that is", you can't just switch that in and expect to keep the same meaning. The change that inspired this update to the doc style is https://github.com/matrix-org/matrix-spec/pull/1424/files#diff-7b8c1672b39828e4d12f305f5a3213c03f902c370bff42627eefb6a9b6f0c2eaR15-R17 and I'm struggling to think of ways to phrase that which are clear and convey the same thing.

In compromise, I have suggested a soft preference for full sentences.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - this feels like a reasonable compromise given our usage.

@richvdh richvdh merged commit a45138c into main Feb 28, 2023
@richvdh richvdh deleted the rav/doc_style_updates branch February 28, 2023 19:04
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants