Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDU check 5 should consult state before an event #1070

Merged
merged 2 commits into from
May 23, 2022
Merged

PDU check 5 should consult state before an event #1070

merged 2 commits into from
May 23, 2022

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented May 18, 2022 •
edited by github-actions bot
Loading

See #1069 for my rationale.

Fixes #1069.

Preview: https://pr1070--matrix-spec-previews.netlify.app

@DMRobertson DMRobertson requested a review from a team as a code owner May 18, 2022 11:54
richvdh
richvdh approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh merged commit c4e5450 into matrix-org:main May 23, 2022
@zecakeh zecakeh mentioned this pull request May 28, 2022
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checks on PDUs is ambiguous when it refers to "the state at an event"
2 participants
@DMRobertson @richvdh