Add 403 error response to federation/v1/state_ids #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes matrix-org#1912 by adding a 403 error response to /_matrix/federation/v1/state_ids/{roomId}
clokep
changed the title
…ver/newsfragments/1926.feature
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
richvdh
requested changes
Aug 14, 2024
Comment on lines
1
to
18
| RESPONSE/server-server/edu.yaml | ||
|
|
||
| Fixes issue #1912 by adding error response to /_matrix/federation/v1/state_ids/{roomId} | ||
|
|
||
| CONTENT : | ||
| "403": | ||
| description: |- | ||
| The host is not in the room or the host is banned from the room via its ACL. | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: ../client-server/definitions/errors/error.yaml | ||
| examples: | ||
| response: | ||
| value: { | ||
| "errcode": "M_FORBIDDEN", | ||
| "error": "You do not have permission to access the state at the requested event." | ||
| } |
There was a problem hiding this comment.
From the rendered output of this PR:
This is not a useful changelog entry.
Please have a look at other changelog fragments, as well as the existing changelog, for examples of what might be appropriate here.
There was a problem hiding this comment.
Yes give me a bit of time I will definitely complete it . Can you also please give me a heads up about why the output is like this and a little bit information about changelog fragments ? Appreciate your help sir
There was a problem hiding this comment.
Have you looked at other examples? Start there. If you still have questions, come back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1912 by adding a 403 error response to /_matrix/federation/v1/state_ids/{roomId}
Pull Request Checklist
Fixes issue #1912 by adding error response to /_matrix/federation/v1/state_ids/{roomId}
Signed-off-by:
Srinjoy Sen Chowdhury [email protected]Preview: https://pr1926--matrix-spec-previews.netlify.app