-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4108: Mechanism to allow OIDC sign in and E2EE set up via QR code #4108
Open
hughns
wants to merge
33
commits into
main
Choose a base branch
from
element-hq/oidc-qr-login
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,592
−0
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6e42f10
Placeholder
hughns d90eda1
MSC4108
hughns f7bbba3
WIP of MSC4108
hughns 177a2db
Auto numbers don't work on non-sequential items
hughns f54e194
High level description of rendezvous protocol and consistency in payl…
hughns f34bec3
Cheat spell checker
hughns 2830e88
Description of rendezvous session API
hughns 24e2242
Add description of QR format
hughns 21ae2ca
Lint
hughns 38eb661
Notes on threat model
hughns 9cd724f
Fix broken link
hughns db759ea
Resolve some more TODOs
hughns 5d6fb4a
Merge branch 'element-hq/oidc-qr-login' of https://github.com/matrix-…
hughns 4e425af
Define POST response body explicitly
hughns a302c39
Add Cache-Control and Pragma HTTP response headers
hughns a81491c
Add error codes
hughns e1f7367
Formatting
hughns d8c62ed
Whitespace
hughns ad31acf
More formatting
hughns aa37af9
Tweaks to the QR code login crypto (#4129)
dkasak 289a810
Add missing device id check step to sequence diagram
hughns 25e8fcb
Remove references to rendezvous session ID
hughns e12945c
Fix POST endpoint and Location references
hughns 4f9a4a4
Rendezvous sessions should have a fixed lifetime and allow enough tim…
hughns fbb30ec
Set max payload size to 4KB and fix content-type as text/plain (#4134)
hughns fe939be
Cross signing is mandatory
hughns 76f175b
Use unstable prefix for errcode
hughns 0ca3dea
The If-Match header on PUT requests contains the ETag
hughns 02f18e1
Fix description of 304 GET response
hughns f49fd7f
Fix m.login.failure reason typo
hughns 73da95a
Fix originator of m.login.declined
hughns 87f8317
Use server name rather than base URL and clarify well-known discovery
hughns 0b315f5
Update 4108-oidc-qr-login.md
hughns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 60 seconds is very tight if you have a slow connection, not because of bandwidth but because of latency in establishing the various connections. I'd go for 180 seconds, which I have to admit is just a guesstimate.