Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4033: Explicit ordering of events for receipts #4033

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

MSC4033: Explicit ordering of events for receipts #4033

wants to merge 51 commits into from

Commits on Jul 4, 2023

  1. Initial draft

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3c50306 View commit details
    Browse the repository at this point in the history

  2. Update number to MSC4033

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e7983f2 View commit details
    Browse the repository at this point in the history

  3. Fix mis-spelling

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a75a8e5 View commit details
    Browse the repository at this point in the history

  4. Fix another mis-spelling

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    6841e75 View commit details
    Browse the repository at this point in the history

  5. Add some more alternatives

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2521212 View commit details
    Browse the repository at this point in the history

  6. Add TODO list

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    fe83ad9 View commit details
    Browse the repository at this point in the history

  7. Add missing bracket

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3ae4995 View commit details
    Browse the repository at this point in the history

  8. Add an acknowledgements section

    @andybalaam
    andybalaam committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    8414c2e View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Make thread roots not in their thread

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    7e26924 View commit details
    Browse the repository at this point in the history

  2. Add a changelog

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ee19047 View commit details
    Browse the repository at this point in the history

  3. Clarify stream order and handle redactions

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0e17420 View commit details
    Browse the repository at this point in the history

  4. Small clarifications

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a32a3f9 View commit details
    Browse the repository at this point in the history

  5. Include updated defintion of read/unread event

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    58102cf View commit details
    Browse the repository at this point in the history

  6. Provide JSON examples

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8ecb0bb View commit details
    Browse the repository at this point in the history

  7. Remove TODO list

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c452342 View commit details
    Browse the repository at this point in the history

  8. Wrap code blocks in pre

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2d6a03e View commit details
    Browse the repository at this point in the history

  9. Format code with pre only

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    fba3bbe View commit details
    Browse the repository at this point in the history

  10. Fix misplaced space

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f4899a0 View commit details
    Browse the repository at this point in the history

  11. Add missing "in"

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    afa9629 View commit details
    Browse the repository at this point in the history

  12. Explain what the spec issue is about

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    90e5798 View commit details
    Browse the repository at this point in the history

  13. Remove redundant part of main thread definition

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    76217a0 View commit details
    Browse the repository at this point in the history

  14. Reflect the spec saying thread roots are not in main

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c9bdac8 View commit details
    Browse the repository at this point in the history

  15. Restrict to just redacted events being always read

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    501bfac View commit details
    Browse the repository at this point in the history

  16. Add missing "a"

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    17bfe74 View commit details
    Browse the repository at this point in the history

  17. Servers probably also think thread roots are in main

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c02285b View commit details
    Browse the repository at this point in the history

  18. Move thread_id into content thanks to conversation with Nico

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a48c1d0 View commit details
    Browse the repository at this point in the history

  19. Mention 3051 as an alternative to thread_id

    @andybalaam
    andybalaam committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    aeb0650 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Move thread_id to cleartext of content

    @andybalaam
    andybalaam committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d58758f View commit details
    Browse the repository at this point in the history

  2. Cut down to just ordering

    @andybalaam
    andybalaam committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    bbf1c94 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Small brevity improvements

    @andybalaam
    andybalaam committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    36a28e5 View commit details
    Browse the repository at this point in the history

  2. Note that order should be inserted by servers

    @andybalaam
    andybalaam committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    be77a58 View commit details
    Browse the repository at this point in the history

  3. Move order to be a sibling of ts in receipts

    @andybalaam
    andybalaam committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    04c4606 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Reword motivation paragraph 

    Co-authored-by: Patrick Cloke <[email protected]>
    @andybalaam @clokep
    andybalaam and clokep committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6e027e2 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @andybalaam
    andybalaam committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    5499b04 View commit details
    Browse the repository at this point in the history

  3. Mention the specific API used to get older messages

    @andybalaam
    andybalaam committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7493391 View commit details
    Browse the repository at this point in the history

  4. Make clear the order only needs to increase relative to messages in t… 

    …he same room.

Co-authored-by: Patrick Cloke <[email protected]>
    @andybalaam @clokep
    andybalaam and clokep committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7d3df44 View commit details
    Browse the repository at this point in the history

  5. Formatting

    @andybalaam
    andybalaam committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c45a5e4 View commit details
    Browse the repository at this point in the history

  6. Clarify the consistency guarantees and meaning of order

    @andybalaam
    andybalaam committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1b668ce View commit details
    Browse the repository at this point in the history

  7. Include order in redacted events too

    @andybalaam
    andybalaam committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d2fe0f4 View commit details
    Browse the repository at this point in the history

  8. Emphasise the room level when talking about server calculation

    @andybalaam
    andybalaam committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    694317e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Add a note that this applies to other users' receipts too

    @andybalaam
    andybalaam committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    be0f7ac View commit details
    Browse the repository at this point in the history

  2. Acknowledge that we actually are changing the definition of read/unread

    @andybalaam
    andybalaam committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e650a11 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fix typo 

    Co-authored-by: Matthew Hodgson <[email protected]>
    @andybalaam @ara4n
    andybalaam and ara4n committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7d1728e View commit details
    Browse the repository at this point in the history

  2. Fix missing e in mxid 

    Co-authored-by: Matthew Hodgson <[email protected]>
    @andybalaam @ara4n
    andybalaam and ara4n committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    12cde91 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Make order on a receipt mandatory

    @andybalaam
    andybalaam committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6950a59 View commit details
    Browse the repository at this point in the history

  2. Document the idea of just never sending receipts that don't have orde… 

    …r when we get them
    @andybalaam
    andybalaam committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2543428 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Add a note about fully-read markers being out of scope

    @andybalaam
    andybalaam committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    605eadd View commit details
    Browse the repository at this point in the history

  2. Add notes about negative event order

    @andybalaam
    andybalaam committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d749fb1 View commit details
    Browse the repository at this point in the history

  3. Add a note about negative order meaning event is read

    @andybalaam
    andybalaam committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6859b8d View commit details
    Browse the repository at this point in the history

  4. Add a note about order not being identical

    @andybalaam
    andybalaam committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d2cc49d View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Fix spelling error

    @andybalaam
    andybalaam committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c7a8192 View commit details
    Browse the repository at this point in the history