Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3839: primary-identity-as-key #3839
base: main
Are you sure you want to change the base?
MSC3839: primary-identity-as-key #3839
Changes from all commits
be959a8
0a26cdf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zander wrote
I don't think that's fair. I take no view as to which solution is preferable, but if there are two proposals to solve a problem, it is absolutely on-topic to describe why you see another solution as preferable.
Everyone: we aim to achieve consensus on what constitutes a good change to the spec, and we do that via discussion. People will have different opinions, and that is fine, but please be nice about it, and assume good intent rather than malice. Expressions such as "Back in the real world" and "Do a search for..." are, frankly, condescending and are more likely to aggravate than lead to quality discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everyone should be able to say what is wrong with this one, which is better solved in another one. But maybe the details of how its better solved should be on "the other one". Especially when its mostly personal opinion as what we observed this week is mostly propoaganda of another solution and coming up with not very well researched reasons why this one is bad.
Thank you for hiding the messages, I hope we can see more pragmatic work here going forward.