Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3821: Update the redaction rules, again #3821

Merged
merged 7 commits into from
Jun 19, 2023
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions proposals/3821-update-redaction-rules-again.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Update redaction rules, again
turt2live marked this conversation as resolved.
Show resolved Hide resolved

The current [redaction algorithm](https://spec.matrix.org/v1.6/rooms/v9/#redactions) are
still missing some key fields, even after [MSC2176](https://github.com/matrix-org/matrix-spec-proposals/pull/2176)
attempted to fix some of the obvious cases. This MSC aims to fix more fields.

## Proposal

*Note*: It is recommended to read [MSC2176](https://github.com/matrix-org/matrix-spec-proposals/pull/2176)
before this proposal as MSC2176 contains a lot of backing context.

In a new room version due to redactions affecting event hashes, we:
turt2live marked this conversation as resolved.
Show resolved Hide resolved

* `m.room.member` events additionally preserve part of `third_party_invite` under `content`, if present:
clokep marked this conversation as resolved.
Show resolved Hide resolved
* Spec: https://spec.matrix.org/v1.6/client-server-api/#mroommember
* Under `third_party_invite`, `signed` is preserved. Rationale being that the `signed` block is required
for the server to validate the event, however excess fields and `display_name` are not as important.
turt2live marked this conversation as resolved.
Show resolved Hide resolved
Clients which are trying to represent a redacted `m.room.member` event with `third_party_invite` should
not rely on `display_name` being present but rather state "Bob accepted a third party invite" or similar.
turt2live marked this conversation as resolved.
Show resolved Hide resolved

## Unstable prefix

Implementations looking to test these changes before adopted into a stable room version should use
`org.matrix.msc3821.opt1` as the room version, using v9 as a base and treating it as unstable.